Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

understanding-dvc: copy edits #694

Merged
merged 8 commits into from
Oct 13, 2019
Merged

Conversation

gagejustins
Copy link
Contributor

Copy edits for the understanding DVC docs section

@shcheklein shcheklein temporarily deployed to dvc-org-pr-694 October 13, 2019 16:11 Inactive
@jorgeorpinel
Copy link
Contributor

Thanks Justin. @shcheklein so we want to maintain this section or should we save some time and skip it for now? (Context: #425)

@jorgeorpinel jorgeorpinel changed the title Understanding dvc copy edits understanding-dvc: copy edits Oct 13, 2019
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. since we are planning to dissolve this whole section into other docs I'm able to approve this work without much review actually. Will leave up to Ivan to merge or set aside for now. Also lmk if you'd prefer a detailed review from me here.

@gagejustins
Copy link
Contributor Author

Cool, they're pretty small edits anyway. Feel free to merge whenever (I can't)

@shcheklein
Copy link
Member

@jorgeorpinel I think it's still valuable to edits since these (some) materials will move to the use guide.

@gagejustins thanks!

@shcheklein shcheklein merged commit e9c7ab4 into master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants