test: migrate from unittest to pytest

[efiop]

Need to stop using unittest's TestCase and use pytest instead.

[Suor]

Should we raise this in priority?

Also, looks like we have 3 parts here:

• migrate test_data_cloud.py, look at tests/remotes.py
• migrate external dep tests
• migrate all other unit tests

[efiop]

@Suor This one is still nice-to-have, but it doesn't mean that we can't take it 🙂 Considering the data_cloud complications, I suspect that it will take a bit longer to resolve this one, so I would take it after we migrate to new fixtures. Let's not add this one to the sprint for now.

[Suor]

Maybe open a free hunt on it? @efiop @MrOutis @pared @skshetry?

[efiop]

@Suor Let's not do that in this sprint for now, let's deal with what we have for now. Could consider including into the next one though, let's discuss on grooming.

[efiop]

Migrating tests/func/test_data_cloud.py

[skshetry]

The unittest based tests have started to rot as we rarely update them compared to the fixtures. The diskcache changes removed the repo.state context manager, which made the tests prone to failure raising PermissionError in Windows as we were not closing the sqlite connection (which we still aren't). It was quite easy to debug and fix on pytest, but quite difficult on unittest based tests. Also to solve it, I had to add more hacks which I don't like (see: #5962). 😞

[nik123]

In one of my PRs I've been asked #6339 (comment) to replace unittest.mock with pytest-mock. Is replacement of unittest.mock with pytest-mock is a part of this issue?

[karajan1001]

In one of my PRs I've been asked #6339 (comment) to replace unittest.mock with pytest-mock. Is replacement of unittest.mock with pytest-mock is a part of this issue?

I think so.

[skshetry]

Closed by #8523.