-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: improve output when import stage is fixed to an unchanged rev? #2696
Comments
The |
Yeah good point. Maybe this is best indeed, to be extra explicit about what happened or did not happen (: p.s. a shorter version of the note text, in case needed: "NOTE: The 'cats-dogs.dvc' import stage is fixed to Git revision 'cats-dogs-v1', which has not moved. See https://man.dvc.org/import for more details." |
I would say improving an output is a good first step (I though don't like NOTE prefix, it should be just a normal simple one sentence output) we can do. |
|
I an against erroring out when nothing changed, this doesn't make sense to me and breaks scripting. On the prefix, I would like to see |
Agreed on both with @Suor . Probably would even avoid all upper case prefix at all. For a good message intention should be clear without providing additional prefixes. Or at least, make it just a regular normal part of the sentence - |
I personally do like those uppercase prefixes, they optimize human text parsing. E.g. you just skip HINT of you know what you are doing or you read only WARNINGs, these are anchors, which help you navigate |
This is related, btw #2605. I don't mind HINT, let's try and see how does it look. |
Current output signals that nothing changed: |
When you import a specific revision that doesn't change, for example a tag like:
And then you try to update, nothing changes because the
rev
never moves. Howeverdvc update
output doesn't really signal this, in fact it says "Saving information..." as if something happened:Although this is correct update behavior (as explained in iterative/dvc.org#735 (comment)), maybe the output could be different when it detects a fixed rev field in the DVC-file, and this rev hasn't changed. It could give an INFO message to suggest the user may have to re-import instead of updating. Something like:
The text was updated successfully, but these errors were encountered: