Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of show_checksum arg for Repo cloud APIs #3383

Closed
shcheklein opened this issue Feb 22, 2020 · 2 comments
Closed

get rid of show_checksum arg for Repo cloud APIs #3383

shcheklein opened this issue Feb 22, 2020 · 2 comments
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring

Comments

@shcheklein
Copy link
Member

Since we don't provide it via CLI anymore (except diff, that will be renamed on the CLI level to show-hash soon) is there a point of supporting them on the Repo API level?

If we think they can help to debug, let's review include proper logger.debug.
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Feb 22, 2020
@weekly-digest weekly-digest bot mentioned this issue Feb 23, 2020
Closed
@efiop efiop added p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring labels Feb 23, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Feb 23, 2020
@efiop
Copy link
Member

efiop commented Feb 23, 2020

It is a leftover from a contributed PR. Will require adjusting tests though, so might happen when we redesign tests.

@efiop
Copy link
Member

efiop commented Oct 8, 2021

No longer relevant, was removed during one of the refactorings.

@efiop efiop closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shcheklein @efiop