plots: remove VegaConverter TODO and update misleading comment
#10023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Oct 15, 2023
| @@ -24,6 +24,7 @@ def test_finding_lists(dictionary, expected_result): | |||
| assert list(result) == expected_result | |||
|
|
|||
|
|
|||
| @pytest.mark.studio | |||
There was a problem hiding this comment.
[F] Marking that Studio relies on this behaviour. The test is
def test_convert(
input_data,
properties,
expected_datapoints,
expected_properties,
):
converter = VegaConverter("f", input_data, properties)
datapoints, resolved_properties = converter.flat_datapoints("r")
assert datapoints == expected_datapoints
assert resolved_properties == expected_properties
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
mattseddon
changed the title
plots: remove VegaConverter TODO and update misleading comment
8 tasks
dberenbaum
approved these changes
Oct 16, 2023
mattseddon
force-pushed
the
remove-todo
branch
from
7a379fd
to
9610c49
Compare
efiop
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #9940 / #9931
This PR removes a TODO + misleading comment from the
VegaConverterclass. The change is already fully tested.For context:
There is code in Studio that duplicates this logic that I will be removing. I spent a good chunk of time going between the codebases because there is contradictory information lying around.