Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: add option to skip imports #10277

Merged
merged 1 commit into from Feb 1, 2024
Merged

status: add option to skip imports #10277

merged 1 commit into from Feb 1, 2024

Conversation

dberenbaum
Copy link
Contributor

Closes #10038. Adds dvc status --no-updates:

$ dvc status
data/data.xml.dvc:
        changed deps:
                update available:   get-started/data.xml (https://github.com/iterative/dataset-registry)

$ dvc status --no-updates
Data and pipelines are up to date.

@dberenbaum dberenbaum requested a review from a team February 1, 2024 19:05
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18a9fea) 90.50% compared to head (7a33c9e) 90.43%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10277      +/-   ##
==========================================
- Coverage   90.50%   90.43%   -0.08%     
==========================================
  Files         493      494       +1     
  Lines       37643    37782     +139     
  Branches     5457     5463       +6     
==========================================
+ Hits        34069    34167      +98     
- Misses       2950     2984      +34     
- Partials      624      631       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit 594716e into main Feb 1, 2024
21 checks passed
@efiop efiop deleted the no-imports branch February 1, 2024 19:49
@AlexandreKempf
Copy link
Contributor

✅ All good for me.
Do we want to have --no-updates or --no-update, and why did you choose the plural version? I am asking out of curiosity and best practices at Iterative :)

@dberenbaum
Copy link
Contributor Author

@AlexandreKempf In general, we try to follow https://clig.dev/ and have not formally adopted any other guidelines. In this case, I don't think we have a convention, and I was following the existing check_updates kwarg to which this flag gets passed.

@AlexandreKempf
Copy link
Contributor

Ok nice, I've never heard of this CLI guidelines site. It is very handy. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc status: reports change for frozen import
3 participants