repro: implement downstream option #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrOutis Just a heads up: your python3x tests failed. |
|
Thanks, @efiop , didn't notice it before 👍 |
efiop
previously requested changes
Apr 24, 2019
ghost
dismissed
efiop’s stale review
implemented your suggestions, @efiop, do you mind reviewing it again?
efiop
reviewed
Apr 24, 2019
efiop
reviewed
Apr 25, 2019
efiop
previously requested changes
Apr 25, 2019
ghost
dismissed
efiop’s stale review
Moved the unit test under command and test both with and without downstream
efiop
reviewed
Apr 25, 2019
Co-Authored-By: mroutis <mroutis@protonmail.com>
efiop
reviewed
Apr 25, 2019
Co-Authored-By: mroutis <mroutis@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our Contributing document?
Does your PR affect documented changes or does it add new functionality that should be documented? If yes, have you created a PR for dvc.org documenting it or at least opened an issue for it? If so, please add a link to it.
iterative/dvc.org#271
Close #1555