Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap: remove plugs (incompatible with classic) #2939

Merged
merged 1 commit into from Dec 11, 2019
Merged

snap: remove plugs (incompatible with classic) #2939

merged 1 commit into from Dec 11, 2019

Conversation

casperdcl
Copy link
Contributor

Minor non-classic cleanup required for https://forum.snapcraft.io/t/classic-confinement-request-for-dvc/14124

confinement 'classic' not allowed with plugs/slots lint-snap-v2_confinement_classic_with_interfaces https://launchpad.net/bugs/1655369

@casperdcl casperdcl added the bug Did we break something? label Dec 11, 2019
@casperdcl casperdcl self-assigned this Dec 11, 2019
@casperdcl casperdcl changed the title remove plugs (incompatible with classic) snap: remove plugs (incompatible with classic) Dec 11, 2019
@casperdcl casperdcl requested a review from efiop December 11, 2019 17:42
efiop
efiop approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 08347c0 into iterative:master Dec 11, 2019
@casperdcl casperdcl deleted the snap branch December 13, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees

@casperdcl casperdcl

Labels
bug Did we break something?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@casperdcl @efiop