Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade jsonpath_ng to latest version #3464

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

skshetry
Copy link
Member

Fix #3456

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry added the bug Did we break something? label Mar 10, 2020
@skshetry skshetry self-assigned this Mar 10, 2020
@skshetry skshetry added this to In progress in DVC 25 Feb - 10 March 2020 via automation Mar 10, 2020
@skshetry skshetry moved this from In progress to Review in progress in DVC 25 Feb - 10 March 2020 Mar 10, 2020
@shcheklein
Copy link
Member

@skshetry looks like CI fails?

@skshetry
Copy link
Member Author

skshetry commented Mar 10, 2020

@shcheklein, yes, it's failing due to a recent change in AWS account. I have pinged @efiop for this.

@efiop efiop merged commit 7f94518 into iterative:master Mar 10, 2020
DVC 25 Feb - 10 March 2020 automation moved this from Review in progress to Done Mar 10, 2020
@skshetry skshetry deleted the fix-3456 branch March 10, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something?
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ERROR: unexpected error - No module named 'jsonpath_ng.bin'; 'jsonpath_ng'
3 participants