Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: rerun stage when command is changed #3922

Merged
merged 1 commit into from Jun 1, 2020

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jun 1, 2020

Previously, the stage would not rerun if the deps/outs are cached
even if the cmd has changed.

Versions affected: >0.93.0

Fixes #3918

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Previously, the stage would not rerun if the deps/outs are cached
even if the cmd has changed.

Versions affected: >0.93.0

Fixes iterative#3918
@skshetry skshetry requested review from pmrowla, efiop and pared June 1, 2020 07:44
@skshetry skshetry self-assigned this Jun 1, 2020
@skshetry skshetry merged commit 076eadc into iterative:master Jun 1, 2020
@skshetry skshetry added this to Done in DVC Sprint 19 May - 2 June 2019 via automation Jun 1, 2020
@skshetry skshetry deleted the fix-3918 branch June 1, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

fill_from_lock called when stage.cmd_chaged == True
2 participants