Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --xlab to --x-label, X_TITLE to X_LABEL, same for y #3948

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Rename --xlab to --x-label, X_TITLE to X_LABEL, same for y #3948

merged 1 commit into from
Jun 3, 2020

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Jun 3, 2020

Renamed:

  • cli options
  • dvcfile plot props
  • template anchors
  • variable names throughout the code

@Suor
Rename --xlab to --x-label, X_TITLE to X_LABEL, same for y
0cde1ae 
Renamed:
- cli options
- dvcfile plot props
- template anchors
- variable names throughout the code
@Suor Suor requested a review from efiop June 3, 2020 13:12
@Suor
Copy link
Contributor Author

Suor commented Jun 3, 2020

Something wrong with network connection on travis.

@dmpetrov
Copy link
Member

dmpetrov commented Jun 3, 2020

Thank you @Suor for noticing this and raising this question before the release :)

dmpetrov
dmpetrov approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@efiop efiop merged commit 9a55b90 into iterative:master Jun 3, 2020
efiop added a commit that referenced this pull request Jun 3, 2020
@efiop
plots: remove print
0510012 
Leftover from #3948

FIxes #3951
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 3, 2020 •
edited

But please also notice #3924 regarding the option argument names (et al.)

@jorgeorpinel jorgeorpinel mentioned this pull request Jun 3, 2020
Merged
jorgeorpinel added a commit to iterative/dvc.org that referenced this pull request Jun 6, 2020
@jorgeorpinel
cmd ref: review and update old plots cmds options
d33aecc 
per iterative/dvc#3948 et al.
@jorgeorpinel
Copy link
Contributor

For docs, this would be best applied in an existing PR: iterative/dvc.org/pull/1382

OK I was able to do this myself in iterative/dvc.org@d33aecc but please update the option argument names to reflect the docs (same PR). Thanks

@efiop
Copy link
Member

efiop commented Jun 8, 2020

@Suor Could you take a look, please?

@efiop
Copy link
Member

efiop commented Jun 8, 2020

@jorgeorpinel Created #3983

This was referenced Jun 8, 2020
Merged
Closed
@jorgeorpinel
Copy link
Contributor

Thank you!

shcheklein pushed a commit to iterative/dvc.org that referenced this pull request Jun 11, 2020
@jorgeorpinel @dmpetrov
Regular updates & plots 1.0 update (#1382)
37f4e90 
* cmd ref: add note that move creates dirs

* cmd ref: improve structure of add ref desc.

* grammar: add some commas

* term: checksum -> hash value in dvcignore guide

* style: lower case bullet text

* cmd ref: remove some redundancy in metrics index

* cmd ref: update plots refs synopsis and descriptions
per iterative/dvc/issues/3924 et al.

* Add plots modify cmd

* typo: CSV->csv

* term: working tree -> workspace
per iterative/dvc/pull/3914

* cmd ref: couple improvements to add ref
per #1382 (review)
and #1382 (review)

* Update config/prismjs/dvc-commands.js

* cmd ref: update plots modify description

* cmd ref: add plots modify to nav, with a few more improvements

* cmd ref: plots --show-json -> --show-vega
per iterative/dvc#3891 (comment)

* rename x-lab to x-label

* cmd ref: review descriptions of plots index, show, and diff

* cmd ref: review and update old plots cmds options
per iterative/dvc#3948 et al.

* cmd ref: a couple more option updates
per #1382 (review)

* cmd ref: emphasize add works with any large file/dir
per #1382 (review)

* cmd ref: updae plots modify top half (definition, description)
per #1382 (review) al.

* cmd ref: improve all plot cmd option descriptions

* Update content/docs/command-reference/plots/modify.md

* cmd ref: review examples (mainly images) in plots modify
per #1382 (comment) et al.

* cmd ref: rephrase info about how data arrays are injected to plot templates
per #1382 (review)

* cmd ref: update info on how targets for for plots show/diff
per #1382 (review)

* cmd ref: double check all plots examples
per #1382 (comment)

* cmd ref: remove info about plots show --select

* cmd ref: update add desc
per #1382 (review)

* cmd ref: re-explain dvc add for dirs
per #1382 (review)

* cmd ref: improve description about targets in plots diff
per #1382 (review)

* cmd ref: make emoji note in plots index
per #1382 (review)

* cmd ref: remove ineffective CSV code block highlighting from plots refs
per #1382 (review)

* get started: improve intro in index

* glossary: remove external deps entry (no need)

* cmd ref: add info about column indexing for headerless tables
per #1382 (comment)

* cmd ref: update template metavar for plots subcommands
per #1382 (review)

* cmd ref: mention YAML is supported for plots
per #1382 (comment)

* cmd ref: rename template metavar again in plots
per #1382 (comment)

* cmd ref: clarify plots modify --no-csv-header
per #1382 (review)

* cmd ref: add note about plots modify in show and diff

* cmd ref: update all plots options again

* cmd ref: more updates to plots et al. per Ivan's review

* cmd ref: multiple plots diff --targets allowed

* cmd ref: update note about detault metrics in index
per #1382 (review)

* cmd ref: emphasize add --recursive is rarely needed
per #1382 (review)

* cmd ref: plots diff: update revisions arg desc
per #1382 (review)

* cmd ref: mention column names and numbers in plots {cmd} -x and -y
per #1382 (review)

* cmd ref: emphasize that metrics diff is not a real diff
per #1382 (review)

* cmd ref: simplify note on plots targets
per #1382 (review)

* cmd ref: how to id colmns in plots modify --no-csv-header
per #1382 (review)

* cmd ref: add default target behavior to plots show and diff
rel: #1382 (review)

* cmd ref: rename plots option --no-header
per iterative/dvc/pull/4001

* cmd ref: term: prop->property (plots)
per #1382 (comment)

* cmd ref: more details on metrics index
per #1382 (review)
and #1382 (review)

* cmd ref: more details on plots index
per #1382 (review)
and #1382 (review)

* cmd ref: note about disply props in plots modify
per #1382 (review)
and #1382 (review)

Co-authored-by: Dmitry Petrov <dmitry.petrov@nevesomo.com>
shcheklein pushed a commit to iterative/dvc.org that referenced this pull request Jun 11, 2020
@jorgeorpinel @dmpetrov
cmd ref: dvc add 1.0 update (#1411)
64182e2 
* cmd ref: add note that move creates dirs

* cmd ref: improve structure of add ref desc.

* grammar: add some commas

* term: checksum -> hash value in dvcignore guide

* style: lower case bullet text

* cmd ref: remove some redundancy in metrics index

* cmd ref: update plots refs synopsis and descriptions
per iterative/dvc/issues/3924 et al.

* Add plots modify cmd

* typo: CSV->csv

* term: working tree -> workspace
per iterative/dvc/pull/3914

* cmd ref: couple improvements to add ref
per #1382 (review)
and #1382 (review)

* Update config/prismjs/dvc-commands.js

* cmd ref: update plots modify description

* cmd ref: add plots modify to nav, with a few more improvements

* cmd ref: plots --show-json -> --show-vega
per iterative/dvc#3891 (comment)

* rename x-lab to x-label

* cmd ref: review descriptions of plots index, show, and diff

* cmd ref: review and update old plots cmds options
per iterative/dvc#3948 et al.

* cmd ref: a couple more option updates
per #1382 (review)

* cmd ref: emphasize add works with any large file/dir
per #1382 (review)

* cmd ref: updae plots modify top half (definition, description)
per #1382 (review) al.

* cmd ref: improve all plot cmd option descriptions

* Update content/docs/command-reference/plots/modify.md

* cmd ref: review examples (mainly images) in plots modify
per #1382 (comment) et al.

* cmd ref: rephrase info about how data arrays are injected to plot templates
per #1382 (review)

* cmd ref: update info on how targets for for plots show/diff
per #1382 (review)

* cmd ref: double check all plots examples
per #1382 (comment)

* cmd ref: remove info about plots show --select

* cmd ref: update add desc
per #1382 (review)

* cmd ref: re-explain dvc add for dirs
per #1382 (review)

* cmd ref: improve description about targets in plots diff
per #1382 (review)

* cmd ref: make emoji note in plots index
per #1382 (review)

* cmd ref: remove ineffective CSV code block highlighting from plots refs
per #1382 (review)

* get started: improve intro in index

* glossary: remove external deps entry (no need)

* cmd ref: update add for 1.0 (1) up to...
before Examples

* cmd ref: 1.0 updates for add (2) - examples

* cmd ref: remove note about comments in add example
per #1411 (review)

Co-authored-by: Dmitry Petrov <dmitry.petrov@nevesomo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmpetrov dmpetrov dmpetrov approved these changes

@efiop efiop Awaiting requested review from efiop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Suor @dmpetrov @jorgeorpinel @efiop