Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap: build fixes #3990

Merged
merged 9 commits into from
Jun 9, 2020
Merged

snap: build fixes #3990

merged 9 commits into from
Jun 9, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jun 9, 2020 •
edited

@casperdcl casperdcl self-assigned this Jun 9, 2020
@casperdcl casperdcl requested a review from efiop June 9, 2020 09:58
@casperdcl casperdcl added bug Did we break something? build Issues/features related to building dvc install packages. p0-critical Critical issue. Needs to be fixed ASAP. ci I keep failing, you keep fixing labels Jun 9, 2020
@casperdcl
Copy link
Contributor Author

casperdcl commented Jun 9, 2020 •
edited

Hmm Travis has a radically different guide suggesting docker, which concludes on the next page to check out cmake, which amusingly has moved on to a different approach identical to what we use here. As of 2 hours ago a minor fix was pushed (Crascit/cmake-snap@7ee6e17) to fix the sudo issue.

Let's just say nothing is documented anywhere.

@casperdcl casperdcl changed the title snap: drop sudo snap: build fixes Jun 9, 2020
@casperdcl casperdcl mentioned this pull request Jun 9, 2020
Closed
8 tasks
@casperdcl casperdcl marked this pull request as ready for review June 9, 2020 20:44
@casperdcl
Copy link
Contributor Author

@efiop ready for merge

@efiop
Copy link
Member

efiop commented Jun 9, 2020

Thank you @casperdcl ! 🙏

@efiop efiop merged commit 5efc3bb into iterative:master Jun 9, 2020
casperdcl added a commit to casperdcl/dvc that referenced this pull request Jun 9, 2020
@casperdcl
snap: v0 channels
b613a42 
Related iterative#3990
Related iterative#3989
@casperdcl casperdcl mentioned this pull request Jun 9, 2020
Merged
6 tasks
efiop pushed a commit that referenced this pull request Jun 13, 2020
@casperdcl
snap: v0: build fixes & updates (#3999)
6f0a05a 
* snap: drop sudo

Fixes #3989

* snap: ci: fix builds

* snap: ci: developer notifications

* snap: minimise size

* debug commit

* Revert "snap: minimise size"

This reverts commit 77b41a9.

* fix image info

* Revert "debug commit"

This reverts commit 232baf0.

* snap: v1 channels

Related: #3872

* snap: v0 channels

Related #3990
Related #3989

* snap: auto-version (major) detect

* ci: fetch --tags explanation & error checking

* snap: update warning framework

* hardocde warning

* add deprecation dev comment

* remove warning on explicit v0 channel

* tidy comment

* fix py2
@erw7 erw7 mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop Awaiting requested review from efiop

Assignees

@casperdcl casperdcl

Labels
bug Did we break something? build Issues/features related to building dvc install packages. ci I keep failing, you keep fixing p0-critical Critical issue. Needs to be fixed ASAP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snap: 'sudo' cannot be used with build provider 'lxd'
2 participants
@casperdcl @efiop