tests: cover run cache with functional tests #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Jun 11, 2020
skshetry
commented
Jun 11, 2020
skshetry
commented
Jun 11, 2020
| return len([os.path.join(r, f) for r, _, fs in os.walk(path) for f in fs]) | ||
|
|
||
|
|
||
| def test_push_pull(tmp_dir, dvc, erepo_dir, run_copy, setup_remote): |
There was a problem hiding this comment.
The tests that are missing now are either low-level tests (which I don't really want to add), and more-higher level tests (eg: that covers CML like use-cases where you push to remote storage and remote branch, get contents to a different machine and try to repro or run).
efiop
reviewed
Jun 11, 2020
| @@ -177,11 +178,19 @@ def _transfer(func, from_remote, to_remote): | |||
|
|
|||
| def push(self, remote): | |||
| remote = self.repo.cloud.get_remote(remote) | |||
| return self._transfer(remote.upload, self.repo.cache.local, remote) | |||
| return self._transfer( | |||
| _log_exceptions(remote.tree.upload, "upload"), | |||
There was a problem hiding this comment.
Added this without moving it to utils or anything. This is a temporary hack, our tree/remote/cache separation will soon allow us to properly handle this. Ideally, we would want to make remote handle run-cache by itself, since it is really not that much different from regular cache, just that the location is unusual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I tried to fix #4016, and also fix discrepancies in push/fetch counts.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏