Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repo lock reentrable and provide a context manager #4416

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Make repo lock reentrable and provide a context manager #4416

merged 1 commit into from
Sep 8, 2020

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Aug 18, 2020 •
edited

Can make locked() work both ways by:

def locked(f):
    if isinstance(f, Repo):
        return lock_repo(f)

    ...

Or provide Repo.locked() context manager sharing implementation - less things to import.

@Suor Suor requested a review from efiop August 18, 2020 12:32
@efiop
Copy link
Member

efiop commented Aug 19, 2020

looks like rwlock is broken, need to take a closer look...

@Suor Suor self-assigned this Sep 1, 2020
@Suor
Copy link
Contributor Author

Suor commented Sep 8, 2020

@efiop should work now

efiop
efiop approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing it! 🙏

@efiop efiop merged commit 67ddb7b into iterative:master Sep 8, 2020
@efiop efiop added the refactoring Factoring and re-factoring label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees

@Suor Suor

Labels
refactoring Factoring and re-factoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Suor @efiop