-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff: Add sort logic to sort diff ouput irrespective of output format… #4459
Conversation
…(default/json/md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @PuneethaPai ! 🙏 Please see some comments above.
Just a small change in test code to pass dict copy instead of original In python both In test I was passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @PuneethaPai ! 🙏
Hi! Does this change the output in the examples of https://dvc.org/doc/command-reference/diff perhaps? Esp. in Comparing tags or branches and https://dvc.org/doc/command-reference/diff#example-using-different-output-formats I guess. |
@jorgeorpinel Good catch! Adjusted in iterative/dvc.org@ee2182a . Thank you! |
Thanks! That was a quick one 🙂 |
…(default/json/md)
Fixes one of the task mentioned in Issue: #2982
I have sorted output irrespective of output format to maintain consistency.