output: dont rely on the default hash type #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prerequisite for iterative#4144 and iterative#3069
efiop
commented
Aug 25, 2020
Comment on lines
+45
to
+47
| item.info = get_in(checksums, [key, path], {}) | ||
| item.info = item.info.copy() | ||
| item.info.pop("path", None) |
There was a problem hiding this comment.
For the record: Discussed with @skshetry that we really need to move serialization/loading to specific deps/outputs (e.g. in a form of custom loaders/dumpers). So this is a temporary workaround.
efiop
changed the title
efiop
changed the title
efiop
commented
Aug 25, 2020
| ) | ||
|
|
||
|
|
||
| def test_dump_multiple_hashes(dvc): |
There was a problem hiding this comment.
We don't use this actively right now, but this is a result of us treating loading out.info as a leftover of unparsed values, which needs symmetry on dumping as well. Could've put a few asserts to check that there is only one hash in info, though...
efiop
changed the title
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #4144 and #3069
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏