Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print dvc version info for debugging #4536

Merged
merged 4 commits into from
Sep 13, 2020
Merged

Conversation

karajan1001
Copy link
Contributor

fix #4095

  1. separate info from DVC version.
  2. print DVC version info when some unexpected error occurred.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

fix iterative#4095
1. seperate info from dvc version.
2. print dvc version info when some unexpected error occured.
Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI pass - original build failure was a travis windows worker crash (unrelated to these changes), failed job has been restarted

dvc/utils/pkg.py Outdated
Comment on lines 6 to 10

if PKG is None:
package = ""
else:
package = f"({PKG})"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is only used in info.py, so let's maybe leave it there.

karajan1001 and others added 2 commits September 10, 2020 09:01
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job @karajan1001!

@efiop efiop merged commit 8b16af9 into iterative:master Sep 13, 2020
@efiop
Copy link
Member

efiop commented Sep 13, 2020

Thank you so much @karajan1001 ! πŸ™

@efiop efiop added the enhancement Enhances DVC label Sep 14, 2020
@karajan1001 karajan1001 deleted the fix_4095 branch April 7, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc: print dvc version to debug
4 participants