-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print dvc version info for debugging #4536
Conversation
fix iterative#4095 1. seperate info from dvc version. 2. print dvc version info when some unexpected error occured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI pass - original build failure was a travis windows worker crash (unrelated to these changes), failed job has been restarted
dvc/utils/pkg.py
Outdated
|
||
if PKG is None: | ||
package = "" | ||
else: | ||
package = f"({PKG})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is only used in info.py
, so let's maybe leave it there.
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job @karajan1001!
Thank you so much @karajan1001 ! π |
fix #4095
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π