Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config option for HTTP method for uploads (Artifactory) #4553

Merged
merged 4 commits into from
Sep 10, 2020

Conversation

rfdickerson
Copy link

@rfdickerson rfdickerson commented Sep 9, 2020

Use case

Our MLE team at Expedia Group uses JFrog's Artifactory for storing binary artifacts. While Artifactory supports an HTTP/HTTPS interface, instead of POST it only accepts PUT for the new artifacts. This PR provides an alternative in this case.

Documentation change:
iterative/dvc.org#1769

JFrog Artifactory HTTP REST API

Thank you for the contribution - we'll try to review it as soon as possible. 🙏


This change is Reviewable

@rfdickerson rfdickerson changed the title allow for a config option for http method Allow config option for http method Sep 9, 2020
dvc/tree/http.py Outdated Show resolved Hide resolved
@rfdickerson rfdickerson changed the title Allow config option for http method Allow config option for HTTP method for uploads Sep 9, 2020
dvc/tree/http.py Outdated Show resolved Hide resolved
@efiop
Copy link
Member

efiop commented Sep 9, 2020

Could you please contribute a doc fix for HTTP in https://dvc.org/doc/command-reference/remote/modify to include this new config option?

And one more thing, I see that github is not able to tie your commit's author with your github profile. Likely you just need to add the email used in those commits to https://github.com/settings/emails

@dmpetrov
Copy link
Member

dmpetrov commented Sep 9, 2020

JFrog's Artifactory for storing binary artifacts

it only accepts PUT for the new artifacts

@rfdickerson thank you for this Artifactory insight and the change 🚀

We had an internal discussion about a month ago regarding possible integration with tools like Artifactory and realized that we are lacking hands-on experience with these tools.

I'd really appreciate it if you could share your experience. Please let me know if we can set up a quick chat - I can shoot an email to the address from your profile.

@rfdickerson rfdickerson changed the title Allow config option for HTTP method for uploads Allow config option for HTTP method for uploads (Artifactory) Sep 9, 2020
@rfdickerson
Copy link
Author

rfdickerson commented Sep 9, 2020

@dmpetrov would love a quick chat and maybe a quick screen share demo of it working. My Expedia address should work fine.

dvc/tree/http.py Outdated Show resolved Hide resolved
Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rfdickerson ! 🙏

@efiop efiop merged commit 7fa90e4 into iterative:master Sep 10, 2020
@rfdickerson rfdickerson deleted the feature/put branch September 10, 2020 13:23
@efiop efiop added feature request Requesting a new feature feature is a feature and removed feature request Requesting a new feature labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants