Run CI for Python3.9 #4647
Merged
Run CI for Python3.9 #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, `dvc[hdfs]` install will be a no-op till we have a pyarrow wheel for 3.9. Note that this does not add an entry to the classifier claiming it supports 3.9, that will be added when 3.9 gets released (or, wait for pyarrow to be released).
Also, fix the python version regex for `3.9.0b5` like versions.
libxml does not have wheels for Python39. We do compile them on Linux and Mac
skshetry
added
the
build
skshetry
moved this from In progress
to Review in progress
in DVC 22 September - 6 October 2020
|
These test failures look completely unrelated. Looks like CI is not that stable. |
efiop
reviewed
Sep 30, 2020
efiop
reviewed
Sep 30, 2020
| from tests.unit.output.test_local import TestLocalOutput | ||
|
|
||
|
|
||
| @pytest.mark.skipif(PY39, reason=PYARROW_NOT_AVAILABLE) |
There was a problem hiding this comment.
I guess we could've created a custom marker, but this will do too.
efiop
approved these changes
Sep 30, 2020
efiop
reviewed
Sep 30, 2020
| @@ -1,4 +1,10 @@ | |||
| import os | |||
| import sys | |||
|
|
|||
| # FIXME: Search and replace these from the tests if pyarrow wheel is available | |||
There was a problem hiding this comment.
This will get lost. How about a ticket? (Yeah, that one could be lost too 🙂 ).
There was a problem hiding this comment.
It won't, as I will come to this next week, as soon as Python3.9 gets released.
Windows tests for Python3.8 was failing intermittently. Note: Also removed the realpath wrap around self.root_dir as it's already a realpath when `Git` is instantiated.
skshetry
commented
Oct 1, 2020
Comment on lines
+180
to
181
| if not path_isin(os.path.realpath(gitignore), self.root_dir): | ||
| raise FileNotInRepoError(path) |
There was a problem hiding this comment.
This exception here does not seem very precise,
efiop
approved these changes
Oct 1, 2020
|
Thank you! 🙏 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run CI for Python3.9, skips hdfs tests for 3.9
d673e2a
Also,
dvc[hdfs]install will be a no-op till we havea pyarrow wheel for 3.9.
Note that this does not add an entry to the classifier
claiming it supports 3.9, that will be added when 3.9
gets released (or, wait for pyarrow to be released).
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏