Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiments: store experiments in refs/exps instead of heads #4910

Merged
merged 33 commits into from
Dec 2, 2020

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Nov 19, 2020

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Related to #4897.

  • Experiments no longer uses separate .dvc/experiments clone/workspace
  • Experiments are now stored under a custom git refspec namespace: refs/exps/...
    • Queued experiments are stored in a separate stash: refs/exps/stash
  • Experiment executors are now populated and collected by pushing/fetching git refs
  • dvc exp checkout has been replaced with dvc exp apply
    • Experiment results are no longer applied to the user's workspace by default
    • dvc exp apply will apply the changes from an experiment to the workspace (as unstaged changes)
  • Experiments can be named at runtime using dvc exp run -n/--name <name> ... (also applies to resume w/modified branch params)
  • dvc exp branch <experiment> <branch_name> can be used to promote an experiment to a normal (refs/heads/...) Git branch
  • All other existing behavior remains unchanged from the UI perspective

TODO:

  • dvc exp branch will "promote" an experiment branch to traditional (refs/heads) git branch
  • Support human-readable experiment ref names

@pmrowla pmrowla added the A: experiments Related to dvc exp label Nov 19, 2020
@pmrowla pmrowla self-assigned this Nov 19, 2020
@pmrowla pmrowla added this to In progress in DVC 17 November - 1 December 2020 via automation Nov 19, 2020
@pmrowla pmrowla mentioned this pull request Nov 20, 2020
2 tasks
@pmrowla pmrowla force-pushed the exp-custom-refs branch 5 times, most recently from 6ae4624 to f02ae52 Compare November 30, 2020 09:27
@pmrowla pmrowla moved this from In progress to Review in progress in DVC 17 November - 1 December 2020 Dec 1, 2020
@pmrowla pmrowla marked this pull request as ready for review December 1, 2020 12:28
@pared pared moved this from Review in progress to Done in DVC 17 November - 1 December 2020 Dec 1, 2020
@pmrowla pmrowla changed the title [WIP] experiments: store experiments in refs/exps instead of heads experiments: store experiments in refs/exps instead of heads Dec 2, 2020
@pmrowla pmrowla merged commit 176a23e into iterative:master Dec 2, 2020
@pmrowla pmrowla deleted the exp-custom-refs branch December 2, 2020 12:21
@jorgeorpinel
Copy link
Contributor

@pmrowla I had an idea: since your PR descriptions have pretty complete explanations of what's being done, can we list them all somewhere (perhaps in https://github.com/iterative/dvc/wiki/Experiments) as a first step towards QA and docs this month? Thanks!

@pmrowla
Copy link
Contributor Author

pmrowla commented Dec 7, 2020

@jorgeorpinel As far as anything user-facing goes, everything from these PRs is already on the wiki page.

As far as viewing all the PRs goes, you can just filter by the experiments label:
https://github.com/iterative/dvc/pulls?q=is%3Apr+label%3Aexperiments+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants