parse: parse target correctly for generated stages #4961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even the title says correctly, this is done to support stages that was generated using a complex data, which is not officially supported.
eg:
Here, the list has dict inside which is something that's not supported officially. This will generate stages having name similar to the
build@{'level': 15}
, which works, but thedvc repro <stage>
fails as the target parser looks for:
to differentiate between file path and the stage name (eg: we support running single stage viadvc repro ../dvc.yaml:build2
).Though, I have to say, the parsing is getting complex. :(
Fixes #4957
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏