plots: make linear and scatter interactive #4975
Conversation
| @@ -107,13 +107,15 @@ def _check_field_exists(data, field): | |||
| raise NoFieldInDataError(field) | |||
|
|
|||
|
|
|||
| class DefaultLinearTemplate(Template): | |||
| class DefaultTemplate(Template): | |||
There was a problem hiding this comment.
I would consider dropping this one at some point, for sake of interactive linear to become the default, though one thing that is stopping me from proposing it right away is the simplicity of the default plot, which definitely makes the learning curve for custom plots smoother.
| "width": 300, | ||
| "height": 300, |
There was a problem hiding this comment.
Since we do not store those values anymore in json files, they are not straightforward to edit, without creating a custom template, so I though making them a little bigger will be a good thing.
| @@ -300,27 +302,95 @@ class NormalizedConfusionTemplate(Template): | |||
| } | |||
|
|
|||
|
|
|||
| class DefaultScatterTemplate(Template): | |||
There was a problem hiding this comment.
Default in the name does not make sense, its not default in any way other than, all plots prepared by us are "default" for dvc.
pared
requested review from
efiop,
pmrowla,
skshetry,
elleobrien and
dmpetrov
|
Hi! I'm just trying to understand what this means. I guess just changes to those 2 plots templates? Is it worth mentioning something about this in https://dvc.org/doc/command-reference/plots#plot-templates ? Thanks @pared |
|
@jorgeorpinel the only change is that the plots are interactive now, (hover the mouse over examples) i don't think any change is required. |
Got it. I didn't know what you meant by "interactive". OK, thanks |
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #4902
This change improves user experience for plots.
lineartemplate