Move Repo.collect and collect_granular to Repo.stage
#4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feels like they belong there.
No other tests have been added. Some replacements from `dvc.collect` and `dvc.collect_granular` to `dvc.stage.*` has been made.
efiop
approved these changes
Nov 30, 2020
skshetry
commented
Nov 30, 2020
| @@ -66,368 +50,3 @@ def test_destroy(tmp_dir, dvc, run_copy): | |||
| "dir/subdir/file", | |||
| ]: | |||
| assert not System.is_symlink(tmp_dir / path) | |||
|
|
|||
|
|
|||
| def test_collect(tmp_dir, scm, dvc, run_copy): | |||
There was a problem hiding this comment.
All of these tests are moved to test_stage_load.py.
skshetry
added
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these belong together.
collectandcollect_granulartoStageLoad.collectandcollect_granulartotest_stage_load.py.No other tests have been added.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏