tree: update hint about missing deps #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Dec 1, 2020
Comment on lines
+126
to
+127
| "pip": f"pip install 'dvc[{scheme}]'", | ||
| "conda": f"conda install -c conda-forge dvc-{scheme}", |
There was a problem hiding this comment.
could also colorize it a bit like in updater. Just for consistency.
EDIT: ok, updater needs some refactor too. Keeping as is.
efiop
commented
Dec 1, 2020
| "\n" | ||
| f"\t{cmd}\n" | ||
| "\n" | ||
| f"See {link} for more info." |
There was a problem hiding this comment.
Have thought about adding a troubleshooting entry, but doesn't seem worth it, as install instructions already have extras described.
efiop
commented
Dec 1, 2020
Comment on lines
-121
to
-122
| " 1) Install specific missing dependencies:\n" | ||
| " pip install {}\n" |
There was a problem hiding this comment.
The usefulness of this and all is questionable and it seems more confusing than helpful. Left only one specific command instead.
Related to iterative#4997 Fixes iterative#4987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4997
Fixes #4987
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏