Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdav: use root url to check and on mkdir to find recurse depth #5742

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Mar 31, 2021

The assumption that the root of the URL to be / is incorrect. Just rolling back the changes made in b87e76a for the webdav.

No tests added as it's hard to test this, without changing the server root address. This was working before and I did verify it locally.

Fixes #5588

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry added the bugfix fixes bug label Mar 31, 2021
@skshetry skshetry requested a review from efiop March 31, 2021 05:54
@skshetry skshetry self-assigned this Mar 31, 2021
@skshetry skshetry added this to In progress in DVC 23 March - 06 April 2021 via automation Mar 31, 2021
Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! πŸ™

@efiop efiop merged commit 098a519 into iterative:master Mar 31, 2021
DVC 23 March - 06 April 2021 automation moved this from In progress to Done Mar 31, 2021
@skshetry skshetry deleted the fix-5588 branch March 31, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Webdav connection fails under dvc 2.0.x
2 participants