Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: bump fsspec/s3fs/gcsfs to 2021.5.0 #6056

Merged
merged 1 commit into from
May 25, 2021
Merged

setup: bump fsspec/s3fs/gcsfs to 2021.5.0 #6056

merged 1 commit into from
May 25, 2021

Conversation

isidentical
Copy link
Contributor

Resolves #6055

@isidentical isidentical requested a review from efiop May 25, 2021 10:46
@efiop efiop merged commit 50ec64b into master May 25, 2021
@efiop efiop deleted the bump-fsspec branch May 25, 2021 11:54
@jdvala
Copy link

jdvala commented May 26, 2021

Is there any timeline on when this will be released?

@efiop
Copy link
Member

efiop commented May 26, 2021

@jdvala We'll likely release by the next monday. Thank you for your interest! 🙏

@jdvala
Copy link

jdvala commented May 31, 2021

@efiop I hope this is released soon, we are having a lot of troubles in our CI due to fsspec for s3fs and dvc.

@isidentical
Copy link
Contributor Author

isidentical commented May 31, 2021 via email

@jdvala
Copy link

jdvala commented May 31, 2021

Would you mind sharing those troubles? There is no active DVC release with s3fs yet, so there shouldn't be any issues with it (unless you are installing it separately to the environment dvc is installed).

On Mon, May 31, 2021, 9:22 AM Jay Vala @.***> wrote: @efiop https://github.com/efiop I hope this is released soon, we are having a lot of troubles in our CI due to fsspec for s3fs and dvc. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6056 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJKHQJKZMW5TGIMB4PSS5LTQMTMBANCNFSM45PALBRQ .

So the thing is that we are using s3fs (not a direct dependency, dask is using s3fs) in a different project and then importing that project into the current one where DVC is being used, this is type of cyclic dependencies are really a pain to resolve with the new pip resolver (takes ages).

I ran pipgrip on my repo and here is the output

Error: Because no versions of s3fs match >=0.9.0,<2021.4.0 || >2021.4.0,<2021.5.0 || >2021.5.0
 and s3fs (2021.4.0) depends on fsspec (==2021.04.0), s3fs (>=0.9.0,<2021.5.0 || >2021.5.0) requires fsspec (==2021.04.0).
And because s3fs (2021.5.0) depends on fsspec (==2021.05.0), s3fs (>=0.9.0) requires fsspec (==2021.04.0 || ==2021.05.0).
And because my-repo (0.0.3) depends on s3fs (>=0.9.0)
 and dvc[s3] (2.1.0) depends on fsspec (==0.9.0), my-repo (0.0.3) is incompatible with dvc[s3] (2.1.0).
And because . (0.1.dev36) depends on both dvc[s3] (==2.1.0) and my-repo (==0.0.3), . is forbidden.
So, because no versions of . match <0.1.dev36 || >0.1.dev36
 and root depends on . (*), version solving failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup: bump fsspec/s3fs/gcsfs to 2021.5.0
3 participants