Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty string parsing for the command #6074

Merged
merged 1 commit into from
May 28, 2021
Merged

fix empty string parsing for the command #6074

merged 1 commit into from
May 28, 2021

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented May 28, 2021 •
edited

We get the cmd --flag "" as ["cmd", "--flag", ""], so we have to parse the empty string back to the. double quotes.

Fixes #6072

@skshetry skshetry added bugfix fixes bug A: cli Related to the CLI labels May 28, 2021
@skshetry skshetry self-assigned this May 28, 2021
@skshetry skshetry added this to In progress in DVC May 18 - Jun 1 2021 via automation May 28, 2021
@skshetry skshetry enabled auto-merge (squash) May 28, 2021 06:35
@skshetry skshetry merged commit a74855b into iterative:master May 28, 2021
@skshetry skshetry deleted the quote-empty-string branch May 28, 2021 06:51
DVC May 18 - Jun 1 2021 automation moved this from In progress to Done May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skshetry skshetry

Labels
A: cli Related to the CLI bugfix fixes bug
Projects
No open projects
DVC May 18 - Jun 1 2021
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stage add: quotes are missing in dvc.yaml
1 participant
@skshetry