fs: don't automatically create buckets #6086
Conversation
| bucket.create_bucket( | ||
| oss2.BUCKET_ACL_PUBLIC_READ, | ||
| oss2.models.BucketCreateConfig( | ||
| oss2.BUCKET_STORAGE_CLASS_STANDARD | ||
| ), |
There was a problem hiding this comment.
These permissions are clearly bad 🤦 Just shows how neglected oss has been 🙁
There was a problem hiding this comment.
For the record, new and improved implementation is coming soon in https://github.com/iterative/ossfs thanks to @karajan1001 's work. 🙏
|
Hi~ Click for Microsoft Azure Blob Storage in https://dvc.org/doc/command-reference/remote/modify may need a super quick update after this
If possible I'd double check in other places but I think that's the only mention. The Q is, should we state somewhere (or in all the appropriate remotes) that DVC does not create buckets/containers? |
|
@jorgeorpinel Good catch, I didn't realize that we've documented that behavior already. Created iterative/dvc.org#2546 Thank you! 🙏 |
Currently, we have a bit of a mess, where s3 and gs don't create buckets automatically, but azure and oss do. The safe approach here is to simply not create buckets in any of the filesystems. Local/ssh and others are a bit different, as there is no such thing as bucket there, and nonexistend directories are logically part of the path/prefix and not a standalone resource like buckets are.
Pre-requisite for getting rid of fs.path_info.
Fixes #2101
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏