Fix #6205: Fixed diff summary to only show states with values. #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
suggested changes
Jun 26, 2021
There was a problem hiding this comment.
@hadasarik thanks for the PR! See my comments, there's a couple small issues
skshetry
reviewed
Jun 26, 2021
dvc/command/diff.py
Outdated
Comment on lines
114
to
120
| states_values = [] | ||
| for state in states: | ||
| state_value = summary[state] | ||
| if state_value > 0: | ||
| states_values.append(f"{state_value} {state}") | ||
|
|
||
| ui.write(fmt.format_map(summary)) | ||
| ui.write("files summary: " + ", ".join(states_values)) |
There was a problem hiding this comment.
I personally find loops to be confusing for small stuff. Generators/Comprehensions might be clearer of the intent, eg:
summary = ", ".join(generator)Also, ui.write is basically a small wrapper around print, so you could get rid of "+" and just do:
ui.write("files summary:", summary)WDYT?
There was a problem hiding this comment.
@skshetry Fixed :)
pmrowla
approved these changes
Jul 5, 2021
|
Hi @hadasarik @skshetry @pmrowla This require small docs updates to https://dvc.org/doc/command-reference/diff and https://dvc.org/doc/command-reference/exp/apply please (find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Fixes: #6205
Thank you for the contribution - we'll try to review it as soon as possible. 🙏