Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Prevent tqdm from breaking on output #6280

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jul 5, 2021

Before

asciicast

After

asciicast

Note that I haven't been able to figure out adding support for rich's console, so mixing console might interleave other outputs (though not with the tqdm itself thanks to this PR).

Related to #6224.

Thank you for the contribution - we'll try to review it as soon as possible. 馃檹

@skshetry skshetry added enhancement Enhances DVC ui user interface / interaction bugfix fixes bug labels Jul 5, 2021
@skshetry skshetry self-assigned this Jul 5, 2021
@skshetry skshetry requested a review from a team as a code owner July 5, 2021 09:00
@skshetry skshetry requested a review from pmrowla July 5, 2021 09:00
@skshetry skshetry added this to In progress in DVC 29 June - 12 July 2021 via automation Jul 5, 2021
@skshetry skshetry moved this from In progress to Review in progress in DVC 29 June - 12 July 2021 Jul 5, 2021
@pmrowla pmrowla merged commit 6bccb21 into iterative:master Jul 6, 2021
DVC 29 June - 12 July 2021 automation moved this from Review in progress to Done Jul 6, 2021
@skshetry skshetry deleted the tqdm-interleaving branch July 6, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug enhancement Enhances DVC ui user interface / interaction
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants