output: cache loaded tree objects #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
fix-6173
branch
2 times, most recently
from
52015c2
to
7bd469e
Compare
efiop
changed the title
efiop
force-pushed
the
fix-6173
branch
6 times, most recently
from
453a322
to
90f119f
Compare
efiop
changed the title
efiop
added
optimize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick naive fix that reduces
dvc difffrom hours to around ~20sec for a dataset of dozens of thousands of files. That is still bad, but in order to speed it up more, we need to revisit our.dirstorage and switch to using staging inget_dir_cache. That will be revisited after followups for #6308Related to #6173
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏