fsspec: create directories on upload/upload_fobj #6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
fsspec-create-dirs
branch
2 times, most recently
from
82fd88a
to
30858dc
Compare
isidentical
moved this from In progress
to Review in progress
in DVC 13 July - 26 July 2021
isidentical
force-pushed
the
fsspec-create-dirs
branch
from
30858dc
to
5456c23
Compare
isidentical
force-pushed
the
fsspec-create-dirs
branch
from
5456c23
to
9d7ba06
Compare
efiop
approved these changes
Jul 14, 2021
DVC 13 July - 26 July 2021
automation
moved this from Review in progress
to Reviewer approved
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we start adding non-object systems (e.g webdav, ssh) there is now a requirement for
makedirs()calls beforeupload/upload_fobj/copyoperations. Also the_with_bucket, and_strip_bucketfunctions are closely tied with the object filesytems so they are moved under theObjectFsWrapper.