-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push running checkpoint to remote #6332
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
14175c8
Push running checkpoint to remote
karajan1001 770e5bc
Update dvc/repo/experiments/executor/base.py
karajan1001 15036f3
Get the branch name
karajan1001 205ce57
Finish this PR
karajan1001 b6f147a
Update after finally commit
karajan1001 65eb8d6
Some problems found in review
karajan1001 5077862
Update dvc/repo/experiments/executor/base.py
karajan1001 dd7b380
add remote check before auto push
karajan1001 92d9b07
Split current one env into two
karajan1001 7c271b3
Rename DVC_EXP_CHECKPOINT_PUSH to DVC_EXP_AUTO_PUSH
karajan1001 34f4da3
value error
karajan1001 37d2150
Remove getenv_bool switch to env2bool
karajan1001 0cfd8d1
Better on handling dulwich exceptions
karajan1001 ce7cd7d
Name changing removing prints
karajan1001 e666d2e
Update dvc/env.py
karajan1001 50d419f
Some changes in review
karajan1001 5cf541c
Add validation to repo url
karajan1001 dfcc946
Add new type of SCMError
karajan1001 060ec01
Update dvc/repo/experiments/executor/base.py
karajan1001 ffb657a
Use spy tests call counts and args
karajan1001 41aeaaf
Update dvc/scm/git/backend/base.py
karajan1001 488c7f3
Update dvc/scm/git/backend/dulwich.py
karajan1001 4a16226
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 32677a2
Remove validate_git_repo to validate_git_remote
karajan1001 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to have this explicit check? Would this qualify as a valid git remote? Is there some reason to think a user might set
DVC_EXP_GIT_REMOTE
to their local project's root dir?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why fail for an invalid Git remote but only warn for this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git_remote
is just a variable that is either a path/URL to a git repo (including local ones) or a remote name. If this check is hit it means it's a local path that points directly to the current DVC root directory, which in most cases is a valid git repo path.This behavior can be useful - if you do
DVC_EXP_GIT_REMOTE=.
the end result would be that we auto-push DVC cache for your local experiment runs. (The git push step becomes a no-op, the same thing that happens if you do a CLIgit push
to your own current repo directory)