Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print in style by default for errors #6344

Merged
merged 1 commit into from Jul 21, 2021

Conversation

skshetry
Copy link
Member

I mistakenly set the styled parameter default value in the error_write to True, which was printing using rich by default. This caused the messages to also include the ANSI codes to display.

$ dvc add foo
100% Adding...|████████████████████████████████████████|1/1 [00:00, 76.95file/s]

Some targets could not be linked from cache to workspace.
See <[36mhttps://dvc.org/doc/user-guide/troubleshooting#cache-types[39m> for 
more information.
To re-link these targets, reconfigure cache types and then run:

        dvc checkout foo.dvc

To track the changes with git, run:

	git add foo.dvc

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@skshetry skshetry added ui user interface / interaction bugfix fixes bug labels Jul 21, 2021
@skshetry skshetry self-assigned this Jul 21, 2021
@skshetry skshetry added this to In progress in DVC 13 July - 26 July 2021 via automation Jul 21, 2021
@skshetry skshetry requested a review from a team as a code owner July 21, 2021 10:45
@skshetry skshetry enabled auto-merge (squash) July 21, 2021 10:47
@skshetry skshetry merged commit 64587e8 into iterative:master Jul 21, 2021
DVC 13 July - 26 July 2021 automation moved this from In progress to Done Jul 21, 2021
@skshetry skshetry deleted the fix-error-write branch July 21, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug ui user interface / interaction
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants