setup: limit python-benedict version #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for being late. I have a patch that should fix this on #6378. |
skshetry
added a commit
to skshetry/dvc
that referenced
this pull request
Aug 2, 2021
This reverts commit 15de826.
|
@skshetry Oh, it is pretty late in your timezone so I thought you already were off and rushed this quick fix to restore CI. Thank you so much! 🙏 |
efiop
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Fix merging of params when empty Recent release of python-benedict==0.24.1 started ignoring empty dictionaries during merge. The way we expected to work was questionable and also how benedict itself tries to handle the references to empty dictionary is also questionable. I consider this to be a proper way to handle this even if this gets fixed on the benedict side. * Revert "setup: limit python-benedict version (#6377)" This reverts commit 15de826. * add comment for why passing through benedict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #6374 Kudos @skshetry
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏