cleanup index, and add test for used_objs #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
added
enhancement
skshetry
commented
Aug 6, 2021
| @@ -110,7 +110,7 @@ def outs(self) -> Iterator["Output"]: | |||
| yield from stage.outs | |||
|
|
|||
| @property | |||
| def decorated_outputs(self) -> Iterator["Output"]: | |||
| def decorated_outs(self) -> Iterator["Output"]: | |||
There was a problem hiding this comment.
Trying to keep it consistent with outs.
skshetry
commented
Aug 6, 2021
Comment on lines
34
to
-37
|
|
||
| new_index = self.index.add(stage) | ||
| new_index.check_graph() | ||
|
|
There was a problem hiding this comment.
We already do this during the create.
skshetry
force-pushed
the
cleanup-index-test
branch
from
f295b14
to
3611cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏