[6478] Fix 401 unauthorized for directories in basic auth protected http remote #6479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonlsk Looks like it is breaking our tests, could you take a look, please? @isidentical FYI |
|
@efiop, sorry about that, that should be fixed now. |
efiop
reviewed
Aug 24, 2021
efiop
reviewed
Aug 24, 2021
efiop
reviewed
Aug 24, 2021
|
@simonlsk Thanks for the PR! 🙏 Looks good! Please see a few minor comments above. |
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
for more information, see https://pre-commit.ci
…monlousky/dvc into bug/http-directory-files-unauthorized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #6478
Thank you for the contribution - we'll try to review it as soon as possible. 🙏