ref: use fs.checksum instead of get_mtime_and_size #6495
Merged
+97
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
pmrowla
approved these changes
Aug 27, 2021
|
I'm thinking of extending Index/State to keep track of sizes too so that we can easily get the total sizes that we are going to fetch/push. So, we should still use |
|
@skshetry What do you need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using get_mtime_and_size(+inode in state) as a checksum, to make sure that file didn't change. We don't really care about any underlying values, only the final checksum that is a combination of fs-specific values (mtime, size, inode, etc).
In case of ref objects, we are only using
get_mtime_and_sizefor files and not for directories, which makes it really easy to migrate to fsspec-compatiblefs.checksum(). We also don't ever save refodb anywhere persistent, so we can tweak checksums later if we find a need.Pre-requisite for making state work with any filesystem.