Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine: add dvc machine ssh #6501

Merged
merged 7 commits into from
Sep 1, 2021
Merged

machine: add dvc machine ssh #6501

merged 7 commits into from
Sep 1, 2021

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Aug 30, 2021

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Will close #6483

  • Adds dvc machine ssh command to connect to dvc machine createed remote machine instances - shell/PTY session is done via asyncssh and does not require the user to have a separate OpenSSH/putty/etc SSH client on their machine (meaning it should work from Windows hosts out of the box as long as dvc[terraform] is installed)
  • Adds ssh requirements to the terraform install extras - eventually ssh may need to be added to the default installed remotes if/when dvc machine has basic functionality independent of terraform

@pmrowla pmrowla added the A: executors Related to the executors feature label Aug 30, 2021
@pmrowla pmrowla requested a review from a team as a code owner August 30, 2021 06:36
@pmrowla pmrowla self-assigned this Aug 30, 2021
@pmrowla pmrowla added this to In progress in DVC 24 Aug - 07 Sep 2021 via automation Aug 30, 2021
@pmrowla pmrowla requested a review from efiop August 30, 2021 06:36
@pmrowla pmrowla moved this from In progress to Review in progress in DVC 24 Aug - 07 Sep 2021 Aug 31, 2021
@pmrowla pmrowla enabled auto-merge (squash) September 1, 2021 05:27
@pmrowla pmrowla merged commit 9fc4c60 into iterative:master Sep 1, 2021
DVC 24 Aug - 07 Sep 2021 automation moved this from Review in progress to Done Sep 1, 2021
@pmrowla pmrowla deleted the machine-ssh branch September 1, 2021 07:20
@efiop efiop added the feature is a feature label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: executors Related to the executors feature feature is a feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

machine: provide SSH shell access to created instances
4 participants