Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: bump fsspec/s3fs/gcsfs/adlfs/sshfs to 08.01 #6524

Merged
merged 2 commits into from
Sep 6, 2021
Merged

setup: bump fsspec/s3fs/gcsfs/adlfs/sshfs to 08.01 #6524

merged 2 commits into from
Sep 6, 2021

Conversation

isidentical
Copy link
Contributor

No description provided.

@isidentical isidentical requested a review from a team as a code owner September 2, 2021 11:03
efiop
efiop reviewed Sep 2, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@karajan1001
Copy link
Contributor

For the OSSFS, 2021.8.0. It now gets endpoint from env variable, related to #6320

@isidentical
Copy link
Contributor Author

Seems like we are getting timeouts due to pip's new dependency resolution system.

@isidentical
Copy link
Contributor Author

depends on: iterative/PyDrive2#133

@isidentical isidentical self-assigned this Sep 3, 2021
@isidentical isidentical added this to In progress in DVC 24 Aug - 07 Sep 2021 via automation Sep 3, 2021
@isidentical
Copy link
Contributor Author

Seems like some stuff changed regarding how the links are handled in the fsspec, which makes our tests fail: reported at fsspec/filesystem_spec#742

@isidentical
Copy link
Contributor Author

Let's temporarily switch to os.path.lexists() instead of the self.fs.exists(), since otherwise it would block progress in other features as well (e.g http)

@isidentical isidentical moved this from In progress to Review in progress in DVC 24 Aug - 07 Sep 2021 Sep 6, 2021
@isidentical isidentical merged commit b8b6ace into master Sep 6, 2021
DVC 24 Aug - 07 Sep 2021 automation moved this from Review in progress to Done Sep 6, 2021
@isidentical isidentical deleted the bump-fsspec-8 branch September 6, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop left review comments

@skshetry skshetry skshetry approved these changes

@karajan1001 karajan1001 Awaiting requested review from karajan1001

Assignees

@isidentical isidentical

Labels
maintenance
Projects
No open projects
DVC 24 Aug - 07 Sep 2021
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@isidentical @karajan1001 @efiop @skshetry