extract transfer related logic from odb to fs.utils.transfer #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Sep 6, 2021
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def transfer( |
There was a problem hiding this comment.
I am planning to add support for the callback in the transfer here, so extracting to fs.utils. move will definitely cause an issue, not sure how to handle that without an extra size call.
There was a problem hiding this comment.
Also, upload/download_file/upload_fobj requires support for callbacks. I am thinking of adding callback parameter in these functions, and keep the progress bar support in the filesystem that we have for now, if callback argument is not passed. Then, replace it with appropriate callbacks as we refactor and then get rid of the Tqdm progress bars inside fs.
skshetry
force-pushed
the
move-transfer
branch
from
48aee80
to
3506617
Compare
As local odb needs to set a mode for dir, we cannot create a directory in the transfer
skshetry
force-pushed
the
move-transfer
branch
from
3506617
to
ce9c177
Compare
efiop
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏