Logging, color and usage #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to keep our own implementation, as we have more versatile cross-platform standard module for it. For now just replacing Logger class guts with redirects to 'logging' module, and writing everything into single logging instance.
These are cmdline shortcuts to change dvc's verbosity without fiddling around with loglevel in dvc.conf. Both are added and handled as a common options for all dvc commands in base cmd class.
Colors help readability, especially in verbose mode. Current color map: Debug: Blue Info: White Warning: Yellow Error: Red
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes usage output, replaces our print's with standard logging module, colorizes output and adds --verbose and --quiet options for cmdline.