Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: support dirs in top level definitions #8159

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

pared
Copy link
Contributor

@pared pared commented Aug 22, 2022

Fixes: #7914

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@pared pared changed the title [WIP] plots: support dirs in top level definitions plots: support dirs in top level definitions Aug 23, 2022
@pared pared marked this pull request as ready for review August 23, 2022 12:33
@pared pared requested a review from a team as a code owner August 23, 2022 12:33
@pared pared requested review from skshetry, dberenbaum and daavoo and removed request for skshetry August 23, 2022 12:33
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM!

@pared pared enabled auto-merge (rebase) August 29, 2022 08:29
@pared pared merged commit 2a4b830 into iterative:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

plots: Support plots directories in dvc.yaml:plots
2 participants