Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: Raise lazy DvcException for Python >= 3.11 #8521

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 94.40% // Head: 94.33% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (a2de111) compared to base (97a8b69).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8521      +/-   ##
==========================================
- Coverage   94.40%   94.33%   -0.08%     
==========================================
  Files         432      432              
  Lines       33433    33436       +3     
  Branches     4645     4648       +3     
==========================================
- Hits        31564    31541      -23     
- Misses       1451     1471      +20     
- Partials      418      424       +6     
Impacted Files Coverage Δ
dvc/utils/hydra.py 80.64% <47.82%> (-19.36%) ⬇️
dvc/repo/experiments/queue/base.py 85.76% <100.00%> (+1.07%) ⬆️
dvc/repo/experiments/run.py 94.87% <100.00%> (+5.98%) ⬆️
tests/func/experiments/test_queue.py 87.09% <0.00%> (-12.91%) ⬇️
dvc/repo/experiments/queue/celery.py 83.73% <0.00%> (-5.75%) ⬇️
dvc/repo/experiments/queue/utils.py 76.66% <0.00%> (-3.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla
Copy link
Contributor

pmrowla commented Nov 3, 2022

LGTM, but we can also remove the check @skshetry added as well

try:
from dvc.utils.hydra import apply_overrides, compose_and_dump
except ValueError:
if sys.version_info >= (3, 11):
raise DvcException(
"--set-param is not supported in Python >= 3.11"
)
raise

@skshetry
Copy link
Member

skshetry commented Nov 3, 2022

@daavoo, also please check if mypy is happy on 3.11.

@daavoo
Copy link
Contributor Author

daavoo commented Nov 3, 2022

@daavoo, also please check if mypy is happy on 3.11.

$ which python
/Users/daviddelaiglesiacastro/miniconda3/envs/test-hydra/bin/python
$ python --version
Python 3.11.0
$ which mypy
/Users/daviddelaiglesiacastro/miniconda3/envs/test-hydra/bin/mypy
$ mypy dvc
Success: no issues found in 246 source files

@daavoo daavoo merged commit 08a643e into main Nov 3, 2022
@daavoo daavoo deleted the lazy-hydra-import branch November 3, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants