import-url: include files entry for cloud versioned dir dependencies
#8528
Conversation
pmrowla
added
A: data-sync
| if not self.hash_info and self.hash_name != "md5": | ||
| md5 = getattr(self.meta, "md5", None) | ||
| if md5: | ||
| self.hash_info = HashInfo("md5", md5) |
There was a problem hiding this comment.
for directories our hash_info is always a dvc md5 (even though the filesystem based output.hash_name may not be md5)
| if not dep.obj: | ||
| dep.obj = dep.get_obj() | ||
| entry.obj = dep.obj | ||
| return entry |
There was a problem hiding this comment.
still undecided if this function belongs in output.get_entry or if we need something like repo.index.build() that takes an output or stage and generates index entries
pmrowla
force-pushed
the
8506-import-url-dir
branch
from
0ae3675
to
c45b410
Compare
Codecov ReportBase: 94.28% // Head: 94.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8528 +/- ##
==========================================
- Coverage 94.28% 94.25% -0.04%
==========================================
Files 431 431
Lines 32812 32825 +13
Branches 4576 4582 +6
==========================================
+ Hits 30937 30938 +1
- Misses 1459 1467 +8
- Partials 416 420 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Will fix #8506