Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push/fetch: cleanup cloud versioning CLI flags behavior #8673

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Dec 8, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Will close #8671

  • Disables support for --run-cache for cloud versioned push/fetch
  • Enables support for --all-branches/tags/commits in cloud versioned fetch
  • Disables support for --all-branches/tags/commits in cloud versioned push

@pmrowla pmrowla added A: data-sync Related to dvc get/fetch/import/pull/push A: cloud-versioning Related to cloud-versioned remotes labels Dec 8, 2022
@pmrowla pmrowla self-assigned this Dec 8, 2022
@pmrowla
Copy link
Contributor Author

pmrowla commented Dec 8, 2022

We can't support pushing multiple revs in cloud versioned remotes, since we will be unable to write the version IDs/etags to the .dvc files for old git commits.

This isn't a problem for fetch/pull, but we could consider disabling the multiple revs flags on fetch/pull just for parity reasons.

@dberenbaum this also means that exp push cannot push cache for cloud versioned remotes

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 93.93% // Head: 93.52% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (4ceabf8) compared to base (876d123).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8673      +/-   ##
==========================================
- Coverage   93.93%   93.52%   -0.41%     
==========================================
  Files         435      456      +21     
  Lines       33537    36256    +2719     
  Branches     4733     5242     +509     
==========================================
+ Hits        31504    33910    +2406     
- Misses       1601     1842     +241     
- Partials      432      504      +72     
Impacted Files Coverage Ξ”
dvc/repo/worktree.py 9.77% <0.00%> (ΓΈ)
dvc/repo/push.py 52.38% <42.85%> (-6.45%) ⬇️
dvc/repo/fetch.py 71.01% <58.82%> (-6.96%) ⬇️
dvc/stage/cache.py 87.97% <100.00%> (ΓΈ)
dvc/repo/plots/__init__.py 87.08% <0.00%> (ΓΈ)
dvc/stage/__init__.py 93.96% <0.00%> (ΓΈ)
dvc/repo/experiments/__init__.py 87.27% <0.00%> (ΓΈ)
dvc/version.py 50.00% <0.00%> (ΓΈ)
dvc/machine/__init__.py 74.77% <0.00%> (ΓΈ)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit ace3ba0 into iterative:main Dec 9, 2022
@pmrowla pmrowla deleted the worktree-revs branch December 9, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cloud-versioning Related to cloud-versioned remotes A: data-sync Related to dvc get/fetch/import/pull/push
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

cloud versioning: disable run cache push/pull
2 participants