Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: fix regressions to top-level plots #8703

Merged
merged 2 commits into from
Dec 20, 2022
Merged

plots: fix regressions to top-level plots #8703

merged 2 commits into from
Dec 20, 2022

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Dec 15, 2022

Fixes regressions in #8421.

  1. Makes plots work again when y is a list.
plots:
  plot1.csv:
    y:
      - acc
      - loss
    x: epoch
  1. Supports y lists as one of multiple data sources like:
plots:
  plot:
    y:
      plot1.csv:
        - acc
        - loss
      plot2.csv:
        - loss
    x:
      epoch

@amritghimire @ssachkovskaya I tested with https://studio.iterative.ai/user/dberenbaum/projects/dvc_plots_tests-cvls4xeliq and 1 looks broken (2 seems okay). Not sure if it will get automatically fixed with this change or if something is needed on your end.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 93.52% // Head: 93.53% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b7ebd6c) compared to base (23e4d37).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b7ebd6c differs from pull request most recent head c4907fd. Consider uploading reports for the commit c4907fd to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8703    +/-   ##
========================================
  Coverage   93.52%   93.53%            
========================================
  Files         457      457            
  Lines       36128    36265   +137     
  Branches     5222     5239    +17     
========================================
+ Hits        33790    33920   +130     
- Misses       1837     1844     +7     
  Partials      501      501            
Impacted Files Coverage Δ
tests/unit/render/test_vega_converter.py 100.00% <ø> (ø)
dvc/render/converter/vega.py 91.20% <100.00%> (ø)
dvc/repo/index.py 91.95% <0.00%> (-1.09%) ⬇️
tests/func/test_repo_index.py 96.83% <0.00%> (+1.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum dberenbaum changed the title plots: accept list of y vals plots: fix regressions to top-level plots Dec 16, 2022
@amritghimire
Copy link
Contributor

Tested with this version in studio. The plot works without any change in studio. Let me know if the following is not the desired response.
image

@dberenbaum
Copy link
Contributor Author

Looks good @amritghimire!

@daavoo daavoo added A: plots Related to the plots bugfix fixes bug labels Dec 19, 2022
@daavoo daavoo enabled auto-merge (rebase) December 20, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots bugfix fixes bug
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants