config: expose http timeout in config schema #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.52% // Head: 93.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8722 +/- ##
==========================================
- Coverage 93.52% 93.51% -0.01%
==========================================
Files 457 457
Lines 36229 36195 -34
Branches 5252 5242 -10
==========================================
- Hits 33882 33848 -34
+ Misses 1840 1839 -1
- Partials 507 508 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Related: iterative/dvc-http#25 |
dtrifiro
force-pushed
the
expose-http-timeout
branch
from
fdafc9d
to
b123bea
Compare
skshetry
reviewed
Dec 24, 2022
dtrifiro
force-pushed
the
expose-http-timeout
branch
from
b123bea
to
71534ff
Compare
dtrifiro
force-pushed
the
expose-http-timeout
branch
4 times, most recently
from
071108a
to
df2b698
Compare
skshetry
approved these changes
Jan 5, 2023
- `read_timeout` timeout for reading new data portions from the peer - `connect_timeout` timeout for establishing new connections For more information about individual timeouts meanings: - `read_timeout` maps to `aiohttp`'s `sock_read` timeout - `connect_timeout` applies to `aiohttp`'s `connect`, `sock_connect` timeouts https://docs.aiohttp.org/en/stable/client_reference.html?highlight=clienttimeout#clienttimeout
dtrifiro
force-pushed
the
expose-http-timeout
branch
from
df2b698
to
5ac476f
Compare
dtrifiro
added a commit
to iterative/dvc.org
that referenced
this pull request
Jan 9, 2023
dtrifiro
added a commit
to iterative/dvc.org
that referenced
this pull request
Jan 9, 2023
dtrifiro
added a commit
to iterative/dvc.org
that referenced
this pull request
Jan 23, 2023
dberenbaum
pushed a commit
to iterative/dvc.org
that referenced
this pull request
Jan 23, 2023
… add`) (#4223) * remote modify: remove duplicate config options for s3 * remote modify: add timeout config options for http remote Related: iterative/dvc#8722 * Update content/docs/command-reference/remote/modify.md * Update content/docs/command-reference/remote/modify.md * Revert "Update content/docs/command-reference/remote/modify.md" This reverts commit 5cd4c2b. Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_timeoutmaps toaiohttp'ssock_readtimeout (read timeout while waiting for a new portion of data from the peer)connect_timeoutapplies toaiohttp'sconnect,sock_connecttimeoutsFor more information:
https://docs.aiohttp.org/en/stable/client_reference.html?highlight=clienttimeout#clienttimeout