Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: remove env vars SHELL #8737

Merged
merged 1 commit into from Jan 10, 2023
Merged

gha: remove env vars SHELL #8737

merged 1 commit into from Jan 10, 2023

Conversation

skshetry
Copy link
Member

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 93.54% // Head: 93.54% // Increases project coverage by +0.00% πŸŽ‰

Coverage data is based on head (b549034) compared to base (b25ef5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8737   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         457      457           
  Lines       36254    36255    +1     
  Branches     5262     5262           
=======================================
+ Hits        33914    33915    +1     
  Misses       1835     1835           
  Partials      505      505           
Impacted Files Coverage Ξ”
tests/func/test_repro.py 99.05% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@efiop
Copy link
Member

efiop commented Jan 9, 2023

@skshetry What's the status here?

@skshetry
Copy link
Member Author

skshetry commented Jan 9, 2023

will pick it up after I am done with index cleanup. There's one test failing that has to be fixed.

@skshetry skshetry marked this pull request as ready for review January 10, 2023 04:34
@skshetry skshetry merged commit d87cdba into main Jan 10, 2023
@skshetry skshetry deleted the skshetry-patch-1 branch January 10, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants