Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-url: Update options order #8785

Merged
merged 2 commits into from Jan 10, 2023
Merged

import-url: Update options order #8785

merged 2 commits into from Jan 10, 2023

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jan 10, 2023

Per iterative/dvc.org#3934

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@jorgeorpinel jorgeorpinel added ui user interface / interaction A: cli Related to the CLI labels Jan 10, 2023
dvc/commands/imp_url.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 93.54% // Head: 93.55% // Increases project coverage by +0.00% πŸŽ‰

Coverage data is based on head (e901cb8) compared to base (b25ef5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8785   +/-   ##
=======================================
  Coverage   93.54%   93.55%           
=======================================
  Files         457      457           
  Lines       36254    36253    -1     
  Branches     5262     5261    -1     
=======================================
+ Hits        33914    33915    +1     
+ Misses       1835     1833    -2     
  Partials      505      505           
Impacted Files Coverage Ξ”
dvc/commands/imp_url.py 100.00% <100.00%> (ΓΈ)
dvc/repo/push.py 52.38% <0.00%> (ΓΈ)
dvc/repo/fetch.py 71.01% <0.00%> (ΓΈ)
tests/func/test_repro.py 99.05% <0.00%> (+<0.01%) ⬆️
dvc/repo/worktree.py 9.92% <0.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@jorgeorpinel jorgeorpinel marked this pull request as ready for review January 10, 2023 10:06
@efiop efiop merged commit bccbbc1 into iterative:main Jan 10, 2023
@dberenbaum
Copy link
Contributor

Thanks @jorgeorpinel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cli Related to the CLI ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants